Reported segfault in SmartDashboard.putStringArray

[virtuald]

/cc @celttechie

Windows 10, Python 3.8.1 64-bit. Might be robotpy/robotpy-wpiutil#7?

[auscompgeek]

Quite possibly if the strings are computed. I imagine constants would work by chance.

[auscompgeek]

Actually, hmm. ntcore stores a std::vector<std::string> and references that. vector and string own their contents, right?

[virtuald]

I looked at this a bit deeper, and I haven't been able to reproduce. I think if this were to happen, it would be that somehow an invalid py::str was returned from a function somewhere and added to an array that was used. Lots of pybind11 churn this summer, including a bunch of string stuff, so it's likely this has been addressed.

• Add check if str(handle) correctly converted the object, and throw py::error_already_set if not (bis) pybind/pybind11#2477
• Fail on passing py::object with wrong Python type to py::object subclass using PYBIND11_OBJECT macro pybind/pybind11#2349