Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Subscription features and fix IntraTransport discovery #106

Merged
merged 16 commits into from Jul 3, 2023

Conversation

johnwason
Copy link
Contributor

This PR does the following:

  • Add the UpdateServiceByType() to ServiceSubscription to allow for the desired search types and the filter to be updated without creating a new subscription.
  • Add Attributes filter to the ServiceSubscriptionFilter. This will allow for more flexibility in designing node filters without requiring a custom callback function.
  • Fix the node discovery in IntraTransport that was not working properly. Add the StartClient() function to enable discovery correctly.
  • Fix bug with ServiceSubscriptionClientID taking a reference to NodeID instead of copying in wrappers, leading to a segfault.
  • Add subscription tests using IntraTransport

@johnwason johnwason merged commit 5660d41 into robotraconteur:master Jul 3, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant