Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add (un)timeout and (un)ban functions #110

Merged
merged 11 commits into from
Feb 27, 2021

Conversation

Chronophylos
Copy link
Contributor

@Chronophylos Chronophylos commented Feb 24, 2021

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Copy link
Collaborator

@RAnders00 RAnders00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the proposed changes, see below for the changes I'd like to see. Thanks!

src/client/mod.rs Outdated Show resolved Hide resolved
src/client/mod.rs Outdated Show resolved Hide resolved
src/client/mod.rs Outdated Show resolved Hide resolved
src/client/mod.rs Outdated Show resolved Hide resolved
src/client/mod.rs Outdated Show resolved Hide resolved
src/client/mod.rs Outdated Show resolved Hide resolved
src/client/mod.rs Outdated Show resolved Hide resolved
src/client/mod.rs Outdated Show resolved Hide resolved
src/client/mod.rs Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@RAnders00 RAnders00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made some changes to your code and reworded some documentation. I'll merge this in a few days if you don't have any objections @Chronophylos!

@Chronophylos
Copy link
Contributor Author

Looks good to me

@RAnders00 RAnders00 merged commit 864b17a into robotty:master Feb 27, 2021
@Chronophylos Chronophylos deleted the add-shortcut-functions branch February 27, 2021 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants