handling ros service call fail

[OTL]

rosbridge v2.0 protocol seems it does not support 'Failure of ros service'.
Failure means the service server returns false code.

I think it is better to handle the service result.
Adding

 "result": <bool> 

field to Service Response JSON will solve this problem.
(And if rosbridge server failed to call service, return JSON with this result:false for the response)
How do you think of this topic?

[baalexander]

Hi @OTL, would the status messages specified in the protocol meet your needs?

[OTL]

May be no.

You know that ROS service callback must return boolean value.

rosbridge does nothing if the value is false, and does not send any responce to the client.

status message seems to be different from this.

From iPhone

On 日, 9月 29, 2013 at 10:07 午前, Brandon Alexander <notifications@github.com="mailto:notifications@github.com">> wrote:

Hi @OTL, would the status messages specified in the protocol meet your needs?

—
Reply to this email directly or view it on GitHub.

[rctoris]

Yeah, I see what @OTL is getting at, it appears to be missing from the protocol entirely.

[odestcj]

Agreed. @OTL, would you be willing to submit a pull request with your suggested revision.

Thanks for catching this!

[dabertram]

this might break my code for service providers connected via rosbridge, I will keep an eye on this topic..

[OTL]

I opened #56 .

[rctoris]

It is implemented to be just an extra field in the protocol so it shouldn't break anything (i.e., you can just ignore it)

[jihoonl]

The pull request should have resolved this issue.