Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Native method name mangler handles $ characters incorrectly #120

Closed
ntherning opened this issue Jul 12, 2013 · 2 comments
Closed

Native method name mangler handles $ characters incorrectly #120

ntherning opened this issue Jul 12, 2013 · 2 comments
Labels
bug

Comments

@ntherning
Copy link
Contributor

Apparently $ should become _00024 but the mangler just outputs $. The JNI spec doesn't say anything on which characters need to be converted to hex sequences (_0XXXX) so the mangler currently just converts characters > 0x7f. Maybe we can find the sources for javah somewhere to get a definite answer.

See https://groups.google.com/d/msg/robovm/07KdqLQaTSI/8FXMaafjGRkJ
@ghost ghost assigned ntherning Jul 12, 2013
ntherning added a commit that referenced this issue Jul 12, 2013
@ntherning
The native method mangler will now convert all characters except 0-9,…
80dbbc8 
… a-z and A-Z to _0XXXX unicode sequences to match what javah does. (#120)
@ntherning
Copy link
Contributor Author

AsifHasan: The fix will make it into tonight's nightly. Please wait until tomorrow (GMT+2) and try with the latest nightly from http://download.robovm.org. Let me know if it works so that I can close this issue.

@mdasifhasan
Copy link

Yes it works perfectly now. :)
This issue can be closed.

After downloading the latest robovm, eclipse plugin faced problem as it was expecting 0.0.2 version of roboVM.
Whereas newer version of robovm is 0.0.3
So i uninstalled robovm eclipse plugin and installed latest eclipse plugin from : download.robovm.org/nightlies/eclipse/
Then it worked perfectly from eclipse. 👍

@ntherning ntherning removed their assignment Aug 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ntherning @mdasifhasan