Merge pull request #25 from plievone/start-array

Fix `.start(array)`
robrich · Feb 24, 2014 · 47c6770 · 47c6770 · nchabra · Mar 22, 2014
2 parents fa3b282 + f02face
commit 47c6770
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/index.js b/index.js
@@ -85,7 +85,7 @@ util.inherits(Orchestrator, EventEmitter);
 				if (typeof arg === 'string') {
 					names.push(arg);
 				} else if (Array.isArray(arg)) {
-					names.concat(arg); // FRAGILE: ASSUME: it's an array of strings
+					names = names.concat(arg); // FRAGILE: ASSUME: it's an array of strings
 				} else {
 					throw new Error('pass strings or arrays of strings');
 				}

diff --git a/test/start.js b/test/start.js
@@ -34,7 +34,7 @@ describe('orchestrator', function() {
 		});
 
 		it('should run multiple tasks as array', function(done) {
-			var orchestrator, a, fn, fn2;
+			var orchestrator, a, fn, fn2, fn3;
 
 			// Arrange
 			orchestrator = new Orchestrator();
@@ -45,8 +45,12 @@ describe('orchestrator', function() {
 			fn2 = function() {
 				++a;
 			};
+			fn3 = function() {
+				throw new Error('run wrong task');
+			};
 			orchestrator.add('test', fn);
 			orchestrator.add('test2', fn2);
+			orchestrator.add('test3', fn3);
 
 			// Act
 			orchestrator.start(['test', 'test2']);