Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task timeout #9

Closed
robrich opened this issue Jan 1, 2014 · 4 comments
Closed

Task timeout #9

robrich opened this issue Jan 1, 2014 · 4 comments

Comments

@robrich
Copy link
Owner

robrich commented Jan 1, 2014

Some have expressed concern that if a task doesn't correctly call the callback, Orchestrator hangs indefinitely waiting for it. Should we create a task timeout parameter, default to 1 minute, and if the task doesn't complete in time, automatically fail it?

cc @contra

@yocontra
Copy link
Contributor

yocontra commented Jan 1, 2014

Yeah I think this is reasonable but you should be able to turn it off globally (not Infinity timeout per task)

@robrich
Copy link
Owner Author

robrich commented Jan 1, 2014

Good call on the global timeout.

What's a good timeout period? 1 minute? 10 seconds?

@yocontra
Copy link
Contributor

yocontra commented Jan 2, 2014

20 seconds seems reasonable

robrich added a commit that referenced this issue Feb 11, 2014
@robrich
Copy link
Owner Author

robrich commented Feb 24, 2014

This is done, published in 0.3 I believe.

@robrich robrich closed this as completed Feb 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants