Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Actions #3

Merged
merged 2 commits into from
Dec 8, 2022
Merged

Add GitHub Actions #3

merged 2 commits into from
Dec 8, 2022

Conversation

szabgab
Copy link
Contributor

@szabgab szabgab commented Dec 8, 2022

to run the tests on every push
I disabled Windows as one of the dependencies was failing. If it is important it can be enabled later.

I am sending this as part of my Daily CI project

@robrwo

This comment was marked as outdated.

@szabgab
Copy link
Contributor Author

szabgab commented Dec 8, 2022

fail-fast: false
matrix:
runner: [ubuntu-latest, macos-latest, windows-latest]
perl: [ '5.30', '5.36' ]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to run it on earlier Perls? The module gives v5.10 as minimum, so I'd at least like to run tests on earlier versions of Perl if possible.

@robrwo
Copy link
Owner

robrwo commented Dec 8, 2022

Thanks. I'm fine with this, but can we test earlier Perl versions?

@robrwo robrwo merged commit 9025519 into robrwo:main Dec 8, 2022
@szabgab
Copy link
Contributor Author

szabgab commented Dec 8, 2022

Sure. I only limited it for the initial PR.
I think you can have Linux as early as 5.10 Windows probably only later but it does not work now anyway. I don't know about Mac. Shall I experiment with it and send you a new PR or would you want to do it?

@robrwo
Copy link
Owner

robrwo commented Dec 9, 2022

I think I've gotten it working, thanks.

@szabgab szabgab deleted the ci branch April 6, 2023 08:23
@szabgab
Copy link
Contributor Author

szabgab commented Apr 6, 2023

Hi @robrwo,

I received a lot of value from the open source work of others. This PR was my way of passing on the good deed to someone else. I am trying now to encourage others, you too, to find other project(s) and make a small contribution there. See this issue explaining my reasoning further: OSDC-Code-Maven/OSDC-Code-Maven.github.io#5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants