Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Container Level Output, YAML Formatting, and Sorting #13

Merged
merged 7 commits into from
Apr 5, 2019

Conversation

robscott
Copy link
Owner

@robscott robscott commented Apr 4, 2019

This PR addresses #9 and #11. Lots of changes here, including:

  • Adding container level output option for increased granularity
  • Reworking JSON support to more generic List structure that can output either JSON or YAML
  • Allowing sorting by any of the metrics

@robscott robscott requested a review from endzyme April 4, 2019 13:18
i++
}

sort.Slice(sortedNodeMetrics, func(i, j int) bool {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent! TIL!

Copy link
Collaborator

@endzyme endzyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to be working great! This is awesome!

@robscott robscott merged commit 311014e into master Apr 5, 2019
@robscott robscott deleted the rs/containers branch April 5, 2019 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants