Fix presence with SplitClassDir option, and containing Groups #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a way to indicate that, when unsetting after setting the presence attribute, that the container is no longer there. This makes the Encoders to properly not show the container after it was unset to NotPresent. Also, use Python3 exception raise.
This is needed so the parent classes of presenceContainers have the needed local imports.
Make sure it all works with SplitClasses Option, and serializing after Set/Unset
JoseIgnacioTamayo
force-pushed
the
fix_presence
branch
from
6b689d8
to
cbc27ea
Compare
xavier-contreras
approved these changes
Feb 13, 2024
|
@JoseIgnacioTamayo thanks again for your help here! Do you know when this will be included in a release? |
|
Hi @ianbarrere . I would like to have the currently open PR merged, to make a new release. It should not take long. |
|
Cool, sounds good! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Likely solves #336