fix: fix packetsReceiptNotificationsValue for Android

.prettierignore

@@ -3,3 +3,4 @@ dist
 example/www
 example/ios
 example/android
+example/.angular

.vscode/settings.json

@@ -7,6 +7,7 @@
   "files.eol": "\n",
   "files.insertFinalNewline": true,
   "terminal.integrated.scrollback": 10000,
+  "terminal.integrated.defaultProfile.osx": "zsh",
 
   // Todo tree settings
   "todo-tree.general.tags": ["BUG", "HACK", "FIXME", "TODO", "INFO"],

CONTRIBUTING.md

@@ -8,7 +8,7 @@ This guide provides instructions for contributing to this Capacitor plugin.
 
 #### Android studio
 
-Download and install [Android studio](https://developer.android.com/studio). The code has been developed using `Android Studio Giraffe | 2022.3.1 Patch 3`
+Download and install [Android studio](https://developer.android.com/studio). The code has been developed using `Android Studio Hedgehog | 2023.1.1 Patch 1`
 
 #### Xcode
 

android/src/main/AndroidManifest.xml

@@ -1,12 +1,14 @@
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:tools="http://schemas.android.com/tools"
     package="com.example.plugin.nordicdfu">
+
+    <uses-permission android:name="android.permission.FOREGROUND_SERVICE_CONNECTED_DEVICE" />
+    <uses-permission android:name="android.permission.POST_NOTIFICATIONS" />
+
     <application>
         <service
             android:name=".DfuService"
-            android:foregroundServiceType="connectedDevice" />        
-        <activity android:name=".NotificationActivity"/>
+            android:foregroundServiceType="connectedDevice" />
+            <activity android:name=".NotificationActivity" />
     </application>
-
-    <uses-permission android:name="android.permission.FOREGROUND_SERVICE_CONNECTED_DEVICE" />
-    <uses-permission android:name="android.permission.POST_NOTIFICATIONS" />
 </manifest>

android/src/main/java/com/example/plugin/nordicdfu/NordicDfu.java

@@ -1,9 +1,7 @@
 package com.example.plugin.nordicdfu;
 
-import android.app.NotificationManager;
 import android.content.Context;
 import android.os.Build;
-import android.os.Handler;
 import androidx.annotation.NonNull;
 import androidx.annotation.Nullable;
 import com.getcapacitor.JSObject;

android/src/main/java/com/example/plugin/nordicdfu/NordicDfuPlugin.java

@@ -129,7 +129,7 @@ public void startDFU(PluginCall call) {
             }
 
             if (dfuOptions.has("packetsReceiptNotificationsValue")) {
-                starter.setPacketsReceiptNotificationsValue(dfuOptions.optInt("packetReceiptNotificationsEnabled"));
+                starter.setPacketsReceiptNotificationsValue(dfuOptions.optInt("packetsReceiptNotificationsValue"));
             }
 
             if (dfuOptions.has("forceDfu")) {

ios/Plugin/NordicDfuPlugin.swift

@@ -19,7 +19,7 @@ public class NordicDfuPlugin: CAPPlugin, CBCentralManagerDelegate, DFUServiceDel
         var notification: JSObject = [
             "id": Int(request.identifier) ?? -1,
             "title": request.content.title,
-            "body": request.content.body,
+            "body": request.content.body
         ]
 
         if let userInfo = JSTypes.coerceDictionaryToJSObject(request.content.userInfo) {
@@ -73,7 +73,7 @@ public class NordicDfuPlugin: CAPPlugin, CBCentralManagerDelegate, DFUServiceDel
         return [
             .badge,
             .sound,
-            .alert,
+            .alert
         ]
     }
 
@@ -157,15 +157,15 @@ public class NordicDfuPlugin: CAPPlugin, CBCentralManagerDelegate, DFUServiceDel
             "currentPart": part,
             "partsTotal": totalParts,
             "duration": duration,
-            "remainingTime": remainingTime,
+            "remainingTime": remainingTime
         ]
         sendStateUpdate("DFU_PROGRESS", data)
     }
 
     private func sendStateUpdate(_ state: String, _ data: JSObject = [:]) {
         let ret: JSObject = [
             "state": state,
-            "data": data,
+            "data": data
         ]
         notifyListeners(dfuChangeEvent, data: ret)
     }
@@ -258,8 +258,7 @@ public class NordicDfuPlugin: CAPPlugin, CBCentralManagerDelegate, DFUServiceDel
             // }
 
             if let packetsReceiptNotificationsValueStr = dfuOption["packetsReceiptNotificationsValue"] as? String,
-               let packetsReceiptNotificationsValue = UInt16(packetsReceiptNotificationsValueStr)
-            {
+               let packetsReceiptNotificationsValue = UInt16(packetsReceiptNotificationsValueStr) {
                 starter.packetReceiptNotificationParameter = packetsReceiptNotificationsValue
             }
 

package.json

@@ -39,22 +39,22 @@
     "access": "public"
   },
   "scripts": {
-    "verify": "npm run verify:ios && npm run verify:android && npm run verify:web",
+    "verify": "yarn verify:ios && yarn verify:android && yarn verify:web",
     "verify:ios": "cd ios && pod install && xcodebuild -workspace Plugin.xcworkspace -scheme Plugin -destination generic/platform=iOS && cd ..",
     "verify:android": "cd android && ./gradlew clean build test && cd ..",
-    "verify:web": "npm run build",
-    "lint": "npm run eslint && npm run prettier -- --check && npm run swiftlint -- lint",
-    "fmt": "npm run eslint -- --fix && npm run prettier -- --write && npm run swiftlint -- --fix --format",
+    "verify:web": "yarn build",
+    "lint": "yarn eslint && yarn prettier --check && yarn swiftlint lint",
+    "fmt": "yarn eslint --fix && yarn prettier --write && yarn swiftlint --fix --format",
     "eslint": "eslint . --ext ts",
     "prettier": "prettier \"**/*.{css,html,ts,js,java}\"",
     "swiftlint": "swiftlint",
     "docgen": "docgen --api NordicDfuPlugin --output-readme README.md --output-json dist/docs.json",
-    "build": "npm run clean && npm run docgen && tsc && rollup -c rollup.config.js",
+    "build": "yarn clean && yarn docgen && tsc && rollup -c rollup.config.js",
     "clean": "rimraf ./dist",
     "watch": "tsc --watch",
     "test": "echo \"No test specified\"",
     "prepare": "husky install",
-    "prepublishOnly": "npm run build"
+    "prepublishOnly": "yarn build"
   },
   "devDependencies": {
     "@capacitor/android": "^5.3.0",