fix: fix packetsReceiptNotificationsValue for Android

robsonos · Jan 14, 2024 · e58d828 · e58d828
1 parent fdf116d
commit e58d828
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 9 deletions.
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -7,6 +7,7 @@
   "files.eol": "\n",
   "files.insertFinalNewline": true,
   "terminal.integrated.scrollback": 10000,
+  "terminal.integrated.defaultProfile.osx": "zsh",
 
   // Todo tree settings
   "todo-tree.general.tags": ["BUG", "HACK", "FIXME", "TODO", "INFO"],

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -8,7 +8,7 @@ This guide provides instructions for contributing to this Capacitor plugin.
 
 #### Android studio
 
-Download and install [Android studio](https://developer.android.com/studio). The code has been developed using `Android Studio Giraffe | 2022.3.1 Patch 3`
+Download and install [Android studio](https://developer.android.com/studio). The code has been developed using `Android Studio Hedgehog | 2023.1.1 Patch 1`
 
 #### Xcode
 

diff --git a/android/src/main/AndroidManifest.xml b/android/src/main/AndroidManifest.xml
@@ -1,12 +1,14 @@
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:tools="http://schemas.android.com/tools"
     package="com.example.plugin.nordicdfu">
+
+    <uses-permission android:name="android.permission.FOREGROUND_SERVICE_CONNECTED_DEVICE" />
+    <uses-permission android:name="android.permission.POST_NOTIFICATIONS" />
+
     <application>
         <service
             android:name=".DfuService"
-            android:foregroundServiceType="connectedDevice" />        
-        <activity android:name=".NotificationActivity"/>
+            android:foregroundServiceType="connectedDevice" />
+            <activity android:name=".NotificationActivity" />
     </application>
-
-    <uses-permission android:name="android.permission.FOREGROUND_SERVICE_CONNECTED_DEVICE" />
-    <uses-permission android:name="android.permission.POST_NOTIFICATIONS" />
 </manifest>
diff --git a/android/src/main/java/com/example/plugin/nordicdfu/NordicDfu.java b/android/src/main/java/com/example/plugin/nordicdfu/NordicDfu.java
@@ -1,9 +1,8 @@
 package com.example.plugin.nordicdfu;
 
-import android.app.NotificationManager;
+
 import android.content.Context;
 import android.os.Build;
-import android.os.Handler;
 import androidx.annotation.NonNull;
 import androidx.annotation.Nullable;
 import com.getcapacitor.JSObject;

diff --git a/android/src/main/java/com/example/plugin/nordicdfu/NordicDfuPlugin.java b/android/src/main/java/com/example/plugin/nordicdfu/NordicDfuPlugin.java
@@ -129,7 +129,7 @@ public void startDFU(PluginCall call) {
             }
 
             if (dfuOptions.has("packetsReceiptNotificationsValue")) {
-                starter.setPacketsReceiptNotificationsValue(dfuOptions.optInt("packetReceiptNotificationsEnabled"));
+                starter.setPacketsReceiptNotificationsValue(dfuOptions.optInt("packetsReceiptNotificationsValue"));
             }
 
             if (dfuOptions.has("forceDfu")) {