Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QUESTION: inline labels for DatePicker and TextArea #409

Closed
itsmenewbie03 opened this issue May 2, 2024 · 2 comments · Fixed by #417
Closed

QUESTION: inline labels for DatePicker and TextArea #409

itsmenewbie03 opened this issue May 2, 2024 · 2 comments · Fixed by #417
Labels
enhancement New feature or request

Comments

@itsmenewbie03
Copy link
Contributor

The inline labels for most input looks gorgeous, but for some input like the TextArea and DatePicker, they look a bit off
image
is this intentional?
@robsontenorio
Copy link
Owner

It is not intentional. The dark variant css should be fixed. Could you compare with x-input and send PR ?

@itsmenewbie03
Copy link
Contributor Author

Thanks for confirming, I will try to work on this during my free time (of course if there's anyone who wanna work on this, they're totally free to do it xD) . I have a quite some school works to finish.

@robsontenorio robsontenorio added the enhancement New feature or request label May 2, 2024
@itsmenewbie03 itsmenewbie03 mentioned this issue May 6, 2024
Merged
robsontenorio added a commit that referenced this issue May 8, 2024
@itsmenewbie03 @robsontenorio
feat: improve inline labels for DatePicker and TextArea (#409) (#417)
0ca95a7 
* feat: add `sunday-start` modifier

This allows a cleaner way to make the calendar start on Sunday.

* feat: remove bg-white and dark:bg-gray-900

Removing this makes the inline label appear better as it matches the
labels in most of the inputs.

---------

Co-authored-by: Robson Tenório <rrtenorio@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: improve inline labels for DatePicker and TextArea (#409) itsmenewbie03/mary
2 participants
@robsontenorio @itsmenewbie03