MenuTitle: new component & MenuSeparator: remove title and set correct style #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
REJack
force-pushed
the
feat/menu-header
branch
from
f541515
to
eff3559
Compare
REJack
added a commit
to REJack/mary-ui.com
that referenced
this pull request
Mar 20, 2024
|
Why not modify the current It currently has all necessary attributes (optional), so we would not need a new component. |
REJack
force-pushed
the
feat/menu-header
branch
from
eff3559
to
9adc035
Compare
|
I've updated my PR, with that change my docs PR is not needed too, now I've updated the style + we keep the old title icon feature but with usage of my new MenuTitle. What you think about that? I would still prefer a MenuTitle component to only have a title without separator/divider 😄. |
robsontenorio
force-pushed
the
feat/menu-header
branch
from
32123c6
to
91ad063
Compare
|
Agreed. Reverted to the first commit. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a new component MenuTitle & removed the title from MenuSeparator.
I've removed your default uppercase class to comply with daisyUI default style and it's hard to remove it if you don't want it (like me).
Example Images from maryUI-Docs - Left (modified) / Right (current)
In my use-case it looks like that
Dropdown with a simple MenuTitle and a single MenuSeparator
P.S.: mary-ui.com change/PR is coming too ;)