Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert: make alert dismissable #400

Merged
merged 2 commits into from
Apr 27, 2024
Merged

Conversation

derrok
Copy link
Contributor

@derrok derrok commented Apr 26, 2024

Closes #397

This PR adds the ability to make alerts dismissable.

@derrok
Copy link
Contributor Author

derrok commented Apr 26, 2024

This commit adds the default position for the toast. Now, you don't need to write
$this->success('All done!', 'toast-bottom toast-end')
each time in each of your components if you want to change the default position of your toast. You can write
<x-toast position="toast-bottom toast-end" />
in your layout and use the toast with the simple $this->success('All done!') command.

@robsontenorio
Copy link
Owner

Thanks ! Looks good.

On the next opportunity , please send one PR per feature. Because it’s easier to rollback in case of problems.

But I will handle this as is.

@robsontenorio robsontenorio merged commit db675ef into robsontenorio:main Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QUESTION: how to make the alert component dismissable?
2 participants