New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shortcut for Optional.get named isPresent #113
Comments
Suggestion: if |
I try to use the same names one is already familiar with for feature extraction, IMO this way we have a more intuitive API than inventing new names. We already have |
I mulled your input over and I came to the conclusion that |
I'll work on this |
I think |
@byarr I have updated the description regarding reporting. |
@byarr do you need help? |
@robstoll Sorry, I did take quick look at this. But I havnt really got the time right now. Unassigning myself. |
@byarr no problem if you need longer, just wanted to make sure you are not stuck. Rich out here if you want to take it over again and I re-assign it to you. |
I'll work on this. In the description, you mention "ExtractedFeatureOption" but I don't find this class. I assumed it was ExtractedFeaturePostStep when I looked at the examples provided. Am I right or I am missing something? |
That's correct. The class was renamed since I created this issue |
implemented with 8cd76f3 |
Platform (JVM and/or JS): JVM (only jdk8)
Code related feature
In reporting we want to see for
the following report:
and for
the following
and for
the following:
Following the things you need to do:
lib
domain
ExtractedFeaturePostStep<T, E>
whereT: Optional<E>
(see ResultAssertions.isSucces as a guideline)api
Expect<E>
(see resultAssertions.kt as a guideline) and add@since 0.9.0
to the KDOCExpect<T>
(see resultAssertions.kt as a guideline) and@since 0.9.0
(adopt to current version) to the KDOCYour first contribution?
I'll work on this
if you would like to take this issue over.This way we get the chance to revise the description in case things have changed in the meantime,
we might give you additional hints and we can assign the task to you, so that others do not start as well.
(Invite yourself in case you do not have an account yet).
The text was updated successfully, but these errors were encountered: