Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite misc/tools/atrium-samples-test/build.gradle to build.gradle.kts #1161

Closed
robstoll opened this issue Jun 27, 2022 · 6 comments · Fixed by #1163
Closed

rewrite misc/tools/atrium-samples-test/build.gradle to build.gradle.kts #1161

robstoll opened this issue Jun 27, 2022 · 6 comments · Fixed by #1163
Assignees
Labels
Milestone

Comments

@robstoll
Copy link
Owner

Platform (all, jvm, js): all
Extension (none, kotlin 1.3): none

Code related feature

Would be nicer to have the build file in Kotlin instead of groovy

Your first contribution?

  • Write a comment I'll work on this if you would like to take this issue over.
    This way we get the chance to revise the description in case things have changed in the meantime, we might give you additional hints and we can assign the task to you, so that others do not start as well.
  • See Your first code contribution for guidelines.
  • Do not hesitate to ask questions here or to contact us via Atrium's slack channel if you need help
    (Invite yourself in case you do not have an account yet).
@DNotNice
Copy link

DNotNice commented Jul 1, 2022

Hi, I would like to work on this issue but I am a beginner and haven't worked on writing Gradle files before, it would be great if you could guide me.
Thank You

@robstoll
Copy link
Owner Author

robstoll commented Jul 2, 2022

@Procrasteenator maybe not the best issue to start with in this case. Take a look at 1046.
If you want to continue with this one, then read https://kotlinlang.org/docs/multiplatform-add-dependencies.html and similar sites and compare groovy and Kotlin.

@agataporwit
Copy link

I have some Kotlin experience and would like to challange myself. Would that be a good place to start ? I am open to any suggestions.

@robstoll
Copy link
Owner Author

robstoll commented Jul 5, 2022

@agataporwit give it a go, you will quickly find out if you're lost or not I guess. Ask if you need help 🙂

@robstoll
Copy link
Owner Author

robstoll commented Jul 7, 2022

@agataporwit There is already a PR for this issue by @Stexxe which I just merged.
I hope you have not yet started with your work. In case you have, then you might be interested to compare your work with that of stexxe's see #1163
There are still other good first issues:
https://github.com/robstoll/atrium/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22

@Stexxe
Copy link
Contributor

Stexxe commented Jul 7, 2022

I'll work on this

@robstoll robstoll added this to the 0.19.0 milestone Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants