Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate build file from Groovy to Kotlin DSL of samples-composite project #1163

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Migrate build file from Groovy to Kotlin DSL of samples-composite project #1163

merged 1 commit into from
Jul 7, 2022

Conversation

Stexxe
Copy link
Contributor

@Stexxe Stexxe commented Jul 6, 2022

Fixes #1161


I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.

@Stexxe Stexxe requested a review from robstoll as a code owner July 6, 2022 17:58
@robstoll robstoll merged commit c8f95eb into robstoll:main Jul 7, 2022
@robstoll
Copy link
Owner

robstoll commented Jul 7, 2022

@Stexxe thanks for your first contribution to Atrium 🙂 👍

Please, next time, add the comment I'll work on this to the corresponding issue before you start working on it. There was already someone else working on it which is kind of a pity. Anyway... how about a next one?
https://github.com/robstoll/atrium/issues?q=is%3Aissue+is%3Aopen+label%3A%22help+wanted%22

@Stexxe
Copy link
Contributor Author

Stexxe commented Jul 7, 2022

@robstoll, I don't disturb someone else's work, and it's up to you to decide to merge my pull request or to wait for another one. I don't like to comment like this because, in the end, I may not finish it, so in my opinion, it's better to just deliver a solution, especially for small tasks like this one. I can write I'll work on this just before I create a PR if you want.

@robstoll
Copy link
Owner

robstoll commented Jul 7, 2022

@Stexxe I see your point. Would be good if you could write a comment, only this way I can assign the issue to you. You might want to do this also for #1161 so that I can assign it to you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rewrite misc/tools/atrium-samples-test/build.gradle to build.gradle.kts
2 participants