Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples for CharSequence.toContain... in api-infix #1543

Open
robstoll opened this issue Sep 26, 2023 · 7 comments
Open

samples for CharSequence.toContain... in api-infix #1543

robstoll opened this issue Sep 26, 2023 · 7 comments
Labels

Comments

@robstoll
Copy link
Owner

Platform (all, jvm, js): all
Extension (none, kotlin 1.3): none

Code related feature

we already have corresponding samples in api-fluent, the goal is to copy the following examples to api-infix and transform them to the infix style:

  • apis/fluent/atrium-api-fluent/src/commonTest/kotlin/ch/tutteli/atrium/api/fluent/en_GB/samples/CharSequenceToContainCheckerSamples.kt
  • apis/fluent/atrium-api-fluent/src/commonTest/kotlin/ch/tutteli/atrium/api/fluent/en_GB/samples/CharSequenceToContainCreatorSamples.kt
  • apis/fluent/atrium-api-fluent/src/commonTest/kotlin/ch/tutteli/atrium/api/fluent/en_GB/samples/CharSequenceToContainSearchBehaviourSamples.kt

TODOs:

  • copy the above files
  • transform them to the infix style
  • link from the corresponding functions in the KDOC via @sample (see api-fluent for examples)

Your first contribution?

  • Write a comment I'll work on this if you would like to take this issue over.
    This way we get the chance to revise the description in case things have changed in the meantime, we might give you additional hints and we can assign the task to you, so that others do not start as well.
  • See Your first code contribution for guidelines.
  • Do not hesitate to ask questions here or to contact us via Atrium's slack channel if you need help
    (Invite yourself in case you do not have an account yet).
@robstoll
Copy link
Owner Author

@Nikos-Tsiougranas write a comment if you want to tackle it and I'll assign it to you

@rohitverma007
Copy link

May I work on this? [and potentially few other related ones]

@robstoll
Copy link
Owner Author

robstoll commented Sep 27, 2023

Sure, I suggest you transform one method in CharSequenceToContainCheckerSamples and then create a draft PR so that I can already give you feedback before you continue with the rest. (please don't work on other issues in parallel, once this one is complete, we can find you another issue you can work on -- I have created multiple similar issues because hacktoberfest starts soon and there are always a lot of newcomers to open source development and I would like to give them the chance to work on something easy manageable)

@rohitverma007
Copy link

@robstoll ah ok, created a draft PR for CharSequenceToContainCheckerSamples, let me know how it looks. I will do maybe another one or so and leave the rest.

@robstoll robstoll linked a pull request Sep 27, 2023 that will close this issue
@robstoll
Copy link
Owner Author

Looks all good 👍
Just to avoid confusion, you can tackle all TODOs of this issue. Just leave the other issues for other people. If no one should be interested until end of October, then I am happily coming back to you as I can need your help. And in the meantime, I could also need help for other issues 🙂
https://github.com/robstoll/atrium/issues?q=is%3Aissue+is%3Aopen+label%3A%22help+wanted%22

@rohitverma007
Copy link

@robstoll sounds good will wrap this one up soon and then see if I can tackle some other less easy issues from before.
(also happy to work on other related ones by November if they aren't picked up by then :))

@robstoll
Copy link
Owner Author

@rohitverma007 are you still working on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants