Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding CharSequenceToContainCheckerSamples.kt infix style #1558

Closed
wants to merge 5 commits into from

Conversation

rohitverma007
Copy link

Adding CharSequenceToContainCheckerSamples.kt infix style relates to #1543


I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.

@robstoll robstoll linked an issue Sep 27, 2023 that may be closed by this pull request
@robstoll
Copy link
Owner

robstoll commented Sep 27, 2023

Perfect 👍 please go on with the other two files 👍
(and don't forget to link from the kdoc of the corresponding functions)

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (288b3fe) 91.83% compared to head (94a6b18) 91.83%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1558   +/-   ##
=========================================
  Coverage     91.83%   91.83%           
  Complexity      114      114           
=========================================
  Files           418      418           
  Lines          4531     4531           
  Branches        224      224           
=========================================
  Hits           4161     4161           
  Misses          323      323           
  Partials         47       47           
Flag Coverage Δ
current 91.39% <ø> (ø)
current_windows 90.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

codieai bot and others added 3 commits September 27, 2023 23:59
…trium/api/infix/en_GB/samples/CharSequenceToContainCreatorSamples.kt
PR for samples for CharSequenceToContainCreatorSamples in api-infix
CodieAI First PR!
…trium/api/infix/en_GB/samples/CharSequenceToContainSearchBehaviourSamples.kt (#10)

Co-authored-by: codieai[bot] <146276760+codieai[bot]@users.noreply.github.com>
Copy link
Owner

@robstoll robstoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the links in KDoc are missing (let me know if I shall wait with the review until you mark it as non-draft)


@Test
fun value() {
expect("ABC") toContain exactly(1).value("A")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only half infix 🙂 (I guess this does not compile or does it?)
More things to fix also further below

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@rohitverma007
Copy link
Author

Hey @robstoll thanks for the reviews!
But yes, please hold off once the PR is in non draft.
As you can perhaps tell, I am essentially using this as part of testing an AI bot I am building. It should be able to reiterate as well, but still working on that :)
Once PR is ready to review, I will publish it and would love your input then :)

…trium/api/infix/en_GB/samples/CharSequenceToContainCreatorSamples.kt (#11)

Co-authored-by: codieai[bot] <146276760+codieai[bot]@users.noreply.github.com>
@robstoll
Copy link
Owner

@rohitverma007 Closing this, so it does not pop up under PRs. You can create a new draft (or re-open it) once you progress with your AI project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants