-
-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding CharSequenceToContainCheckerSamples.kt infix style #1558
Conversation
Perfect 👍 please go on with the other two files 👍 |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1558 +/- ##
=========================================
Coverage 91.83% 91.83%
Complexity 114 114
=========================================
Files 418 418
Lines 4531 4531
Branches 224 224
=========================================
Hits 4161 4161
Misses 323 323
Partials 47 47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…trium/api/infix/en_GB/samples/CharSequenceToContainCreatorSamples.kt
PR for samples for CharSequenceToContainCreatorSamples in api-infix CodieAI First PR!
…trium/api/infix/en_GB/samples/CharSequenceToContainSearchBehaviourSamples.kt (#10) Co-authored-by: codieai[bot] <146276760+codieai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, the links in KDoc are missing (let me know if I shall wait with the review until you mark it as non-draft)
|
||
@Test | ||
fun value() { | ||
expect("ABC") toContain exactly(1).value("A") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only half infix 🙂 (I guess this does not compile or does it?)
More things to fix also further below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Hey @robstoll thanks for the reviews! |
…trium/api/infix/en_GB/samples/CharSequenceToContainCreatorSamples.kt (#11) Co-authored-by: codieai[bot] <146276760+codieai[bot]@users.noreply.github.com>
@rohitverma007 Closing this, so it does not pop up under PRs. You can create a new draft (or re-open it) once you progress with your AI project. |
Adding CharSequenceToContainCheckerSamples.kt infix style relates to #1543
I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.