Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add samples for localDateAssertions of api-fluent #996

Closed
3 tasks
robstoll opened this issue Oct 6, 2021 · 3 comments · Fixed by #1006
Closed
3 tasks

add samples for localDateAssertions of api-fluent #996

robstoll opened this issue Oct 6, 2021 · 3 comments · Fixed by #1006
Assignees
Milestone

Comments

@robstoll
Copy link
Owner

robstoll commented Oct 6, 2021

Code related feature

With this issue we want to add samples for localDateAssertions.kt of api-fluent

Following the things you need to do:

api-fluent

  • create LocalDateExpectationSamples in apis/fluent-en_GB/atrium-api-fluent-en_GB-common/src/test/kotlin/ch/tutteli/atrium/api/fluent/en_GB/samples
    • add one function per function in localDateAssertions.kt (see AnyExpectationSamples)
    • refer to the sample in the KDoc of the corresponding function in localDateAssertions via @sample (check out toEqual in anyExpectations.kt to see how you have to refer to the sample)

Your first contribution?

  • Write a comment I'll work on this if you would like to take this issue over.
    This way we get the chance to revise the description in case things have changed in the meantime, we might give you additional hints and we can assign the task to you, so that others do not start as well.
  • See Your first code contribution for guidelines.
  • Do not hesitate to ask questions here or to contact us via Atrium's slack channel if you need help
    (Invite yourself in case you do not have an account yet).
@rhushikesh
Copy link
Contributor

Hi @robstoll,

I have raised a PR for issue #997. Samples required for localDateAssertions are pretty much in line with localDateTimeAssertions. If you are okay with PR of that issue, I can pick this issue up as well and raise required PR.

Thank you

rhushikesh added a commit to rhushikesh/atrium that referenced this issue Oct 9, 2021
rhushikesh added a commit to rhushikesh/atrium that referenced this issue Oct 9, 2021
@robstoll robstoll added this to the 0.17.0 milestone Oct 9, 2021
@robstoll
Copy link
Owner Author

robstoll commented Oct 9, 2021

@rhushikesh great that you have that much time 👍

@rhushikesh
Copy link
Contributor

HI @robstoll,

I have raised PR for this issue #1006. I have accommodated changes you had suggested for localDateTimeAssertions PR as well.

Please have a look and let me know our thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants