Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add createAndAppend to AssertionContainer expecting Translatable #1061

Merged
merged 1 commit into from
Nov 16, 2021

Conversation

robstoll
Copy link
Owner

and no longer rely on assertionBuilder.createDescriptive as it will
be removed in 0.18.0


I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.

and no longer rely on assertionBuilder.createDescriptive as it will
be removed in 0.18.0
@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #1061 (0151dc7) into main (2471c4f) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1061      +/-   ##
============================================
- Coverage     90.59%   90.51%   -0.08%     
  Complexity      107      107              
============================================
  Files           448      448              
  Lines          4666     4672       +6     
  Branches        221      221              
============================================
+ Hits           4227     4229       +2     
- Misses          390      394       +4     
  Partials         49       49              
Flag Coverage Δ
bc 84.82% <0.00%> (-0.11%) ⬇️
current 87.02% <100.00%> (-0.07%) ⬇️
current_windows 86.17% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n/ch/tutteli/atrium/creating/AssertionContainer.kt 100.00% <100.00%> (ø)
...eli/atrium/assertions/builders/AssertionBuilder.kt 45.45% <0.00%> (-36.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2471c4f...0151dc7. Read the comment docs.

@robstoll robstoll merged commit aa33281 into main Nov 16, 2021
@robstoll robstoll deleted the createAndAppend branch November 16, 2021 21:07
@robstoll robstoll added this to the 0.18.0 milestone Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant