Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a showOnlyIf param to withHelpOnFailureBasedOnDefinedSubject #1674

Merged

Conversation

robstoll
Copy link
Owner


I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.

@robstoll robstoll added this to the 1.2.0 milestone Jan 22, 2024
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c7ce68a) 91.83% compared to head (73b789e) 91.83%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1674   +/-   ##
=========================================
  Coverage     91.83%   91.83%           
  Complexity      114      114           
=========================================
  Files           423      423           
  Lines          4604     4605    +1     
  Branches        228      228           
=========================================
+ Hits           4228     4229    +1     
  Misses          330      330           
  Partials         46       46           
Flag Coverage Δ
current 91.40% <100.00%> (+<0.01%) ⬆️
current_windows 90.53% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robstoll robstoll merged commit eeb8971 into main Jan 22, 2024
20 checks passed
@robstoll robstoll deleted the improve/withHelpOnFailureBasedOnDefinedSubject-showOnlyIf branch January 22, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant