compile also specs in source backward compatibility tests #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moreover: - rename DeprecationSpek2TestEngine to Spek2ForgivingTestEngine bcTests will fail with this commit due to: - missing `contains all` function in api-infix (a bug) - StaticName which is internal and not accessible from the new project
moreover: - rename StaticName to StaticNames - don't use it anymore in tests as this causes troubles in bc-tests - remove specs in 0.14.0 about AssertionPlant and co.
use the helper function `keyValue` instead
moreover: - rename TestEngine id from spek2-deprecation to spek2-forgiving
robstoll
force-pushed
the
bc-compile-also-specs
branch
2 times, most recently
from
19baaaa
to
9b1985e
Compare
and fix dependency to translations for infix, should also use de_CH in bc-tests
robstoll
force-pushed
the
bc-compile-also-specs
branch
from
9b1985e
to
3db8cbe
Compare
Codecov Report
@@ Coverage Diff @@
## master #772 +/- ##
============================================
+ Coverage 81.86% 84.84% +2.97%
============================================
Files 420 424 +4
Lines 3998 4024 +26
Branches 213 214 +1
============================================
+ Hits 3273 3414 +141
+ Misses 673 563 -110
+ Partials 52 47 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and fix issues which were revealed due to this.
Fixes #771
I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.