More consise reporting for contains.atLeast(1)

[wordhou]

Resolves #310.

Modifies featureFactory in ContainsAssertionCreator to display a no such item was found text instead of a verbose feature assertion about the number of occurrences, specifically in the case contains.atLeast(1). Creates a descriptionNotFound abstract property on the ContainsAssertionContainer that gets overrode in its subclasses to provide the description for but no such item was found.

I created three new translatables for when an entry is not found, a value is not found, and a charSequence is not found (however they could all be the same if we chose).

---

I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.

[codecov]

Codecov Report

Merging #934 (6905d10) into master (9d97be5) will increase coverage by 0.01%.
The diff coverage is 97.29%.

@@            Coverage Diff             @@
##           master     #934      +/-   ##
==========================================
+ Coverage   91.33%   91.34%   +0.01%     
==========================================
  Files         429      429              
  Lines        4280     4299      +19     
  Branches      215      219       +4     
==========================================
+ Hits         3909     3927      +18     
- Misses        322      323       +1     
  Partials       49       49              

Flag	Coverage Δ
bbc	80.80% <97.29%> (+0.06%)	⬆️
bc	80.71% <97.29%> (+0.06%)	⬆️
current	87.57% <97.29%> (+0.03%)	⬆️
current_windows	86.64% <97.29%> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...s/creators/impl/ContainsObjectsAssertionCreator.kt	94.73% <93.33%> (-5.27%)	⬇️
...contains/creators/impl/ContainsAssertionCreator.kt	100.00% <100.00%> (ø)
...ators/impl/CharSequenceContainsAssertionCreator.kt	100.00% <100.00%> (ø)
...creators/impl/InAnyOrderEntriesAssertionCreator.kt	97.82% <100.00%> (+0.09%)	⬆️
.../creators/impl/InAnyOrderValuesAssertionCreator.kt	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d97be5...6905d10. Read the comment docs.

[robstoll]

IMO listOfNotNull is wrong here as we don't want an emptyList / assertions should be a non-empty list in the end. If you move the call of mismatches inside the if then you can change createExplanatoryGroupForMismatches back to return an AssertionGroup
You need to adjust InAnyOrderEntriesAssertionCreator so that you only call createExplanatoryGroupForMismatches if mismatches is not empty, but there it makes sense because we always have two assertions in the list, so we will never have an empty list

[wordhou]

I see, I didn't realize assertions had to be a non-empty list. When there are no sub-assertions in the list, it seems that we would rather return a descriptive assertion: assertionBuilder.createDescriptive(groupDescription, searchCriterion, trueProvider).build()? However we may need to wrap the descriptive assertion in an invisibleGroup since the searchAndCreateAssertion requires an AssertionGroup and not an Assertion.

[robstoll]

I guess it would be the simplest if we already implement the bonus you describe above. Then we don't need that featureFactory returns AssertionGroup? but can again return AssertionGroup and we escape the null-hell 😆
Isn't it?

[wordhou]

Yes, it seems so!

[wordhou]

Sorry about the recent force-push, I believe I meant to revert rather than reset.

I've made the changes you requested, and I'm fairly sure everything works but I want to point out that the explanatory assertion in the "happy case" is never tested, and I'm not sure how to go about testing those cases.

[robstoll]

No worries about the force push. I am going to write the happy case and assign you as reviewer. This way you will see how it can be accomplished

[robstoll]

@wordhou thanks for this contribution. You are on 🔥 continue like that the Atrium users will be thankful 🙂