Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warning: 'deprecated' attribute directive ignored [-Wattributes] #37

Closed
Teddyz opened this issue Aug 8, 2023 · 6 comments
Closed

warning: 'deprecated' attribute directive ignored [-Wattributes] #37

Teddyz opened this issue Aug 8, 2023 · 6 comments
Assignees
Labels
question Further information is requested

Comments

@Teddyz
Copy link

Teddyz commented Aug 8, 2023

Hello,
I get a lot of these warnings when using version1.0.x
I upgraded Arduino to 2.11 and they are still shown when compiling. I need to have warnings shown to keep my own code in decent shape :)

d:\Mina Dokument\Arduino\libraries\CRC\src/CRC.h:114:48: warning: 'deprecated' attribute directive ignored [-Wattributes] crc_size_t yieldPeriod = CRC_YIELD_DISABLED);

@RobTillaart RobTillaart self-assigned this Aug 8, 2023
@RobTillaart RobTillaart added the question Further information is requested label Aug 8, 2023
@RobTillaart
Copy link
Owner

@Teddyz
With the step to 1.0.0 the library had a serious refactor . This caused a breaking change in several functions,. The old interface was kept with warnings so the "old" code would still work with a warning.

So you need to replace your calls to CRC with the new API calls and then the warnings should disappear.

@RobTillaart
Copy link
Owner

If I understand correctly you use calls to crc32
Please try calcCRC32() calls.

@RobTillaart
Copy link
Owner

@Teddyz
Is the problem solved now?

@Teddyz
Copy link
Author

Teddyz commented Aug 21, 2023

Sorry, I have not looked further at this yet.

It looks to me that the warning I see is for every deprecated in your code, not for the old command I use.
I have another warning for some other old command and that looks ok.

I will come back with better info, you can close this if insufficient info is is provided.

@RobTillaart
Copy link
Owner

OK,
You can always post a minimal sketch that shows the messages so I can try to recreate the issue at hand,

@RobTillaart
Copy link
Owner

As there is no more new info for two months I close this issue.
Feel free to reopen when new information is available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants