Document albatross over tls #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannesm
reviewed
Feb 23, 2023
TLS.md
Outdated
| 16 unikernels on two CPUs. | ||
|
|
||
| ``` | ||
| albatross-provision-request add_policy user 16 --mem 1024 --cpu 0 |
There was a problem hiding this comment.
Suggested change
| albatross-provision-request add_policy user 16 --mem 1024 --cpu 0 | |
| albatross-provision-request add_policy user 16 --mem 1024 --cpu 0 --cpu 1 |
In the text, there's two CPUs -- that should be reflected in the command.
Also I'm wondering whether we need a slight excursion what these cpu arguments are meaning / what they're used for.
There was a problem hiding this comment.
Good catch, thanks. Indeed I was confused by the --cpu <n> option at first I thought <n> was the total number of CPUs allowed, instead of the core ID. I'll make the doc more precise on that matter.
There was a problem hiding this comment.
I have added a commit to make the doc consistent and replaced two CPUs by CPU IDs 0 and 1. It still not very clear what that means as I'm not familiar with the option, so don't hesitate to add something if you want !
hannesm
reviewed
Feb 23, 2023
|
Thanks for writing this up. I added some minor comments. |
Co-authored-by: Hannes Mehnert <hannes@mehnert.org>
|
thanks! :) |
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
May 14, 2023
CHANGES: This is a breaking release since the binaries to be installed have been revised and merged. The `albatross-client-local` is now `albatross-client [--socket]`, `albatross-provision-ca` is now `albatross-client sign` or `albatross-client generate`. The `albatross-client-remote` is now `albatross-client certificate`. The `albatross-client-bistro` is now `albatross-client <command> --destination <host> --ca ca.pem --ca-key ca.pem --server-ca cacert.pem`. And finally, `albatross-tls-inetd` is now `albatross-tls-endpoint --inetd`. - Document TLS usage (robur-coop/albatross#155, robur-coop/albatross#156 @TheLortex @hannesm) - Improve TLS experience by providing more reasonable error messages and apply more checks before establishing a TLS session (robur-coop/albatross#157 @hannesm @reynir) - Slim down binaries: - remove albatross-stat-client binary (robur-coop/albatross#161 @hannesm) - move X509 parts out of Albatross_cli (robur-coop/albatross#158 @reynir) - merge albatross-tls-inetd with albatross-tls-endpoint (robur-coop/albatross#160 @hannesm) - merge albatross-client-inspect-dump into albatross-client (robur-coop/albatross#161 @hannesm) - merge albatross-provision-ca and albatross-provision-request into albatross-client (robur-coop/albatross#159 @reynir @hannesm) - merge albatross-client-remote and albatross-client-bistro and albatross-client-local into albatross-client (robur-coop/albatross#162 @hannesm) - Check solo5 ABI tender version, allow multiple solo5 tenders to exist (named as solo5-{s,h}vt.<ABI> (robur-coop/albatross#163 @hannesm) - Improve documentation and manpages (robur-coop/albatross#164 @hannesm)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a document I synthesized from my experiments.
It might help for the "document" part of #149