Remove evaluated Cstruct.hexdump_pp on guards which slow down our process #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannesm
reviewed
Jan 24, 2024
hannesm
reviewed
Jan 24, 2024
hannesm
reviewed
Jan 24, 2024
hannesm
reviewed
Jan 24, 2024
hannesm
reviewed
Jan 24, 2024
Co-authored-by: Hannes Mehnert <hannes@mehnert.org>
reynir
approved these changes
Jan 24, 2024
|
needs an autoformat run, feel free to merge afterwards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, these
Cstruct‧hexdump_ppare evaluated in any case (the error case and the good case). They slow down our process. This PR remove them (we loose some informations but that's fine).