More garbage friendly cstruct wrapper #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannesm
reviewed
Mar 4, 2024
|
|
||
| (* If we append the empty cstruct and we don't need a fresh copy we can do | ||
| nothing. This has different semantics than Cstruct.append. *) | ||
| let append_nocopy cs cs' = |
There was a problem hiding this comment.
hmm hmm, the name is a bit misleading
There was a problem hiding this comment.
Right, it can't avoid copying in all cases. How about append' then?
There was a problem hiding this comment.
Yes, append' sounds good - or "append_avoid_copy_if_empty"? I'd be interested to upstream this into the Cstruct library, but then it modifies the semantics (that some may rely on, esp. in a concurrent setting), and also I try to remove Cstruct from packages ;)
There was a problem hiding this comment.
I think they might be interesting to upstream. The append alternative would have to have a different name due to differing semantics that might matter in some cases. Then again as you say we probably want to use cstruct less.
hannesm
reviewed
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supercedes #213. This adds a module
Cstruct_extwith functionsappend_nocopythat does not copy if either argument is empty, andsubandshiftvariants that returnCstruct.emptyinstead of the result ofCstruct.suborCstruct.shiftif the result is empty. The reason for this is an empty cstruct still keeps a live reference to its underlying bigarray.