-
Notifications
You must be signed in to change notification settings - Fork 9
/
b18f559.bug
72 lines (72 loc) · 2.11 KB
/
b18f559.bug
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
%YAML 1.1
---
id: b18f559
title: Maintaining Constructs From Old Versions
description: >
A change of protocol was not fully reflected in the code. There
were remnants of the initial version, resulting in two different
topics publishing the same sensor information under different
names. Another issue was having multiple functions that were
doing mostly the same thing, but named accordingly to each
protocol version (e.g. `getData`, `getData2`, `getDefaultData`).
classification: "CWE-477: Use of Obsolete Functions #EVOLUTION"
keywords: ['protocol', 'topics', 'api', 'driver']
system: kobuki
severity: bad-smell
links: []
bug:
phase: runtime
specificity: ROS-specific
architectural-location: application-specific code
application: null
task: null
subsystem: driver
package: yujinrobot/kobuki/kobuki_node
languages: null
detected-by: developer
reported-by: member developer
issue: https://github.com/yujinrobot/kobuki/issues/27
time-reported: 2012-04-09T05:24:47Z
reproducibility: always
trace: null
fix:
pull-request: null
fix-in:
- kobuki_driver/include/kobuki_driver/kobuki.hpp
- kobuki_driver/src/driver/kobuki.cpp
- kobuki_node/include/kobuki_node/kobuki_node.hpp
- kobuki_node/src/nodelets/kobuki_node.cpp
languages:
- C++
time: 2012-04-09 (06:34)
commits:
- repo: https://github.com/yujinrobot/kobuki
hash: b18f55910cc032f967b436b26710c01ec435291d
stats:
total:
insertions: 9
deletions: 80
lines: 89
files: 4
files:
kobuki_driver/include/kobuki_driver/kobuki.hpp:
insertions: 1
deletions: 3
lines: 4
kobuki_driver/src/driver/kobuki.cpp:
insertions: 4
deletions: 56
lines: 60
kobuki_node/include/kobuki_node/kobuki_node.hpp:
insertions: 0
deletions: 1
lines: 1
kobuki_node/src/nodelets/kobuki_node.cpp:
insertions: 4
deletions: 20
lines: 24
fault-codes:
- EVOLUTION:FIRMWARE
failure-codes:
- SOFTWARE:UX
- SYSTEM:NONE