Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

krr version information hasn't been updated since v1.1.1 #76

Closed
danielhass opened this issue Jun 20, 2023 · 1 comment · Fixed by #126
Closed

krr version information hasn't been updated since v1.1.1 #76

danielhass opened this issue Jun 20, 2023 · 1 comment · Fixed by #126
Labels
bug Something isn't working invalid This doesn't seem right

Comments

@danielhass
Copy link

Describe the bug
The krr version information stored in the follow locations has not been bumped since the release of v1.1.1:

This results in wrong package metadata and incorrect output of the version command:

~/git/krr ((HEAD detached at v1.2.1))$ python krr.py version
1.1.1

To Reproduce
Steps to reproduce the behavior:

  1. Clone the git repo
  2. Checkout a specific version tag > 1.1.1 via git checkout tags/v1.2.1
  3. Run the version command: python krr.py version

Expected behavior
The version information and package metadata should be updated on every release.

@LeaveMyYard
Copy link
Contributor

Hey, @danielhass !

I think we are only updating the version in pipelines before packing it in standalone app, but that's confusing.
Thanks from pointing it out, we will fix it

@LeaveMyYard LeaveMyYard added bug Something isn't working invalid This doesn't seem right labels Jun 23, 2023
@LeaveMyYard LeaveMyYard linked a pull request Aug 14, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working invalid This doesn't seem right
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants