RSA keys from existing secret #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the Robusta RSA keys from an existing secret
|
|
|
Hi! Is there any reason this is not reviewed / accepted? |
anakaiti
pushed a commit
to BrioHR/robusta
that referenced
this pull request
Oct 31, 2023
* feat(helm): add the ability to retrieve the Robusta RSA keys from an existing secret. * doc(setup-robusta): add the part mentionning the ability to retrieve the Robusta RSA keys from an existing secret
pavangudiwada
pushed a commit
to pavangudiwada/robusta
that referenced
this pull request
Nov 6, 2023
* feat(helm): add the ability to retrieve the Robusta RSA keys from an existing secret. * doc(setup-robusta): add the part mentionning the ability to retrieve the Robusta RSA keys from an existing secret
|
Any chance of a new tag that includes these changes? It took me a while to work out why this wasn't working, because the documentation for it is already live 😉 |
|
You're right @jmalloc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to implement the ability to retrieve the RSA keys from an existing secret