Use unqualified names for Alertmanager & service discovery URL #1026
Conversation
|
|
helm/robusta/values.yaml
Outdated
| @@ -511,7 +511,7 @@ kube-prometheus-stack: | |||
| - name: 'null' | |||
| - name: 'robusta' | |||
| webhook_configs: | |||
| - url: 'http://robusta-runner.{{ .Release.Namespace }}.svc.cluster.local/api/alerts' | |||
| - url: 'http://robusta-runner.{{ .Release.Namespace }}/api/alerts' | |||
There was a problem hiding this comment.
@yahya-hrln Can you please make it configurable, so it won't change the default behavior for all users?
i.e., put the DNS suffix in a helm value, defaulted to .svc.cluster.local
My concern is, that some users have defined network policies for the existing url, and this change might break it for them
| @@ -18,6 +18,6 @@ def find_service_url(label_selector): | |||
| name = svc.metadata.name | |||
| namespace = svc.metadata.namespace | |||
| port = svc.spec.ports[0].port | |||
| url = f"http://{name}.{namespace}.svc.cluster.local:{port}" | |||
| url = f"http://{name}.{namespace}:{port}" | |||
There was a problem hiding this comment.
Same here,
I would pass the helm value to the runner, using env variable, and use it here
|
@arikalon1 updated |
| @@ -540,7 +543,7 @@ kube-prometheus-stack: | |||
| - name: 'null' | |||
| - name: 'robusta' | |||
| webhook_configs: | |||
| - url: 'http://robusta-runner.{{ .Release.Namespace }}.svc.cluster.local/api/alerts' | |||
| - url: 'http://robusta-runner.{{ .Release.Namespace }}.svc.{{ .Values.global.clusterDomain }}/api/alerts' | |||
There was a problem hiding this comment.
The url you'd like on your case is http://robusta-runner.default/api/alerts right?
What will you put in clusterDomain for your cluster? is it ""
I think that will result in http://robusta-runner.default.svc./api/alerts
Is it working this way?
There was a problem hiding this comment.
In my case, I'll set it to my GKE cluster's custom suffix. So it will still use an FQDN instead of an unqualified name.
| @@ -18,6 +20,6 @@ def find_service_url(label_selector): | |||
| name = svc.metadata.name | |||
| namespace = svc.metadata.namespace | |||
| port = svc.spec.ports[0].port | |||
| url = f"http://{name}.{namespace}.svc.cluster.local:{port}" | |||
| url = f"http://{name}.{namespace}.svc.{CLUSTER_DOMAIN}:{port}" | |||
Fixes #1025