Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update slack sdk to resolve large file timeout issue #1142

Merged
merged 3 commits into from
Feb 12, 2024
Merged

fix: update slack sdk to resolve large file timeout issue #1142

merged 3 commits into from
Feb 12, 2024

Conversation

aiell0
Copy link
Contributor

@aiell0 aiell0 commented Oct 30, 2023

Solve issue: #1141

@CLAassistant
Copy link

CLAassistant commented Oct 30, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@pavangudiwada pavangudiwada added the needs-review A community contribution for Robusta team to review label Nov 16, 2023
@arikalon1
Copy link
Contributor

Thanks for the PR @aiell0

Did you test and it works?
I think we tried upgrading to the new Slack api in the past, but had an issue with it, because it required some additional permissions our app did not have.

arikalon1
arikalon1 approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@arikalon1 arikalon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @aiell0

@arikalon1 arikalon1 merged commit 7829cdb into robusta-dev:master Feb 12, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arikalon1 arikalon1 arikalon1 approved these changes

@aantn aantn Awaiting requested review from aantn

Assignees
No one assigned
Labels
needs-review A community contribution for Robusta team to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aiell0 @CLAassistant @arikalon1 @pavangudiwada