-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extensible Kafka Auth Config #1152
Conversation
…eft blank behavior will be unchanged, if an auth block is used credentials will be unwrapped into the connection arguments.
…ractices, apple-m1 profile can likely be removed at a later date as skaffold will match the architecture of the k8s cluster or runner.
…d best practices, apple-m1 profile can likely be removed at a later date as skaffold will match the architecture of the k8s cluster or runner." This reverts commit 060e8e1.
902282f
to
7dbccf3
Compare
…o include recursive dictionary searches.
Found an issue with my implementation where you couldnt use the elif isinstance(value, dict):
env_var_value = replace_env_vars_values(value)
if env_var_value:
values[key] = env_var_value but this change in the root validator might be more encompassing than the maintainers want, Option B would be to extend just the kafka_sink_params to do a recursive search. Possible Option B.
@validator("auth", pre=True, always=True)
def auth_env_values_validation(cls, value: Dict):
updated = replace_env_vars_values(value)
return updated @LeaveMyYard let me know what you think when you have time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the first solution could be usefull for such cases in a future, so we can keep it
Current kafka sink does not support authentication which makes it difficult to adopt or use in many situations. This PR allows the kafka sink to behave as it is but to have an auth block added to easily cater to most if not all the supported authentications schemas of the python kafka package.
Tested With
Not Tested
additionally updated skaffold configs to the latest version, i can easily roll this back if its not wanted or needed.