add support for setting pod / container security context #1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchmckenzie
force-pushed
the
master
branch
from
2021055
to
e9e2aa8
Compare
|
Thanks for the PR @mitchmckenzie This was merged few days ago: https://github.com/robusta-dev/robusta/pull/1148/files Do we still need this PR? |
|
The previous PR didn't set the container security context for the grafana render. I also like to keep the templates dry by removing the else statements and moving the defaults to the default values file. |
|
Makes sense @mitchmckenzie , thanks for the explanation |
arikalon1
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add support for setting pod / container security context
We use opa gatekeeper to enforce pod / container security policies in our clusters.
To make the robusta deployments compliant we need to be able to set the pod / container security context.
https://open-policy-agent.github.io/gatekeeper/website/