Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): update kube-prometheus-stack to 55.7.0 #1242

Merged
merged 16 commits into from
Feb 19, 2024

Conversation

lippertmarkus
Copy link
Contributor

@lippertmarkus lippertmarkus commented Jan 9, 2024

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jan 9, 2024

CLA assistant check
All committers have signed the CLA.

@lippertmarkus
Copy link
Contributor Author

@aantn could you please have a look? :)

@lippertmarkus
Copy link
Contributor Author

@pavangudiwada do you might have time to review? :)

@pavangudiwada
Copy link
Contributor

We are sorry for the delay @lippertmarkus, our team is looking into this now

@pavangudiwada
Copy link
Contributor

Update: @lippertmarkus I'm working on this PR now, making some final checks for compatibility.

@lippertmarkus
Copy link
Contributor Author

Would be great if we could add an automated process to keep the kube-prometheus-stack dependency up to date

@lippertmarkus
Copy link
Contributor Author

@pavangudiwada @aantn did you have time to review? :)

@pavangudiwada
Copy link
Contributor

Hi @lippertmarkus, extremely sorry, this took way too long than expected. Thank you for your patience. We had to perform many checks to make sure the new version is compatible with the Robusta UI too. We hope this process will be faster next time.

For future reference, here are all the checks we performed:

  1. Install Robusta with updated Kube Prometheus Stack on new GKE and EKS clusters and check for issues. Trigger demo alerts and see if they are working correctly.
    • Ensure there are no errors in pod logs for Prometheus Operator, Alertmanager, Prometheus, and Robusta Runner.
    • Make sure to check oomkilled pods, which should have graphs with data included.
    • Check at least one Prometheus alert (not an APIServer finding):
      • Before enabling managed Prometheus alerts in Robusta (the alert comes straight from KPS).
      • After enabling managed Prometheus alerts (the alert comes from our SaaS).
  2. Upgrade path: Deploy the current version of Robusta without this fix and then deploy with the new KPS version. Look for any errors or issues.
  3. Ensure the functionality in the UI related to these specific pages still works after the updates.
    • AI features.
    • Logs & Graphs on every page in Robusta, including:
      • Apps.
      • App details (a specific app).
      • Nodes.
      • Node details (a specific node).
      • Job details (for a job that ran more than 5 min).
  4. Silences - Can create and view silences.
  5. Efficiency page - Can run a new scan, view the results, and see recommendations (not a ‘?’ sign).
  6. Check the change log for any new changes that we should be aware of.

Copy link
Collaborator

@aantn aantn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@aantn aantn merged commit 40296e8 into robusta-dev:master Feb 19, 2024
8 checks passed
@lippertmarkus lippertmarkus deleted the feat-kubeprom-upd branch February 19, 2024 09:27
@lippertmarkus
Copy link
Contributor Author

can we create a new release including this PR? :)

@aantn
Copy link
Collaborator

aantn commented Mar 6, 2024

Included in 0.10.30!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants