Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed RSA pair #1307

Merged
merged 1 commit into from
Feb 24, 2024
Merged

Removed RSA pair #1307

merged 1 commit into from
Feb 24, 2024

Conversation

ganeshrvel
Copy link
Contributor

No description provided.

arikalon1
arikalon1 approved these changes Feb 24, 2024
View reviewed changes
Copy link
Contributor

@arikalon1 arikalon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work

@arikalon1 arikalon1 merged commit 383adcf into master Feb 24, 2024
16 checks passed
@arikalon1 arikalon1 deleted the enhance/remove-dke branch February 24, 2024 09:24
@arikalon1
Copy link
Contributor

Hi @pavangudiwada

We removed the RSA pair from the default values. (it's not in real use)
Can you please verify that the docs are also aligned?
For example: https://docs.robusta.dev/master/setup-robusta/configuration-secrets.html#pulling-values-from-kubernetes-secrets
Thanks!

@pavangudiwada pavangudiwada mentioned this pull request Feb 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arikalon1 arikalon1 arikalon1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ganeshrvel @arikalon1