feat: add securityContext on pod- and containerLevel for krr jobs #1310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
yanehi
force-pushed
the
feat/set-securityContext-krr-jobs
branch
from
e36aeb2
to
d7d1446
Compare
yanehi
force-pushed
the
feat/set-securityContext-krr-jobs
branch
from
d7d1446
to
bad608b
Compare
LeaveMyYard
approved these changes
Mar 11, 2024
|
thanks for the PR @yanehi ! |
|
Hi @yanehi I'm going to revert this fix, since the new default behavior failed on gke, eks and openshift Can you provide an alternative solution, that the default behavior is not changed? Maybe adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the krr jobs should run with non-root ids and least privileges.
These are set to pod and containerLevel.