Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid adaptive card body for Webex sink #1328

Merged
merged 1 commit into from
Mar 10, 2024

Conversation

ppmathis
Copy link
Contributor

@ppmathis ppmathis commented Mar 8, 2024

This PR fixes an issue with the currently used adaptive card body for the Webex sink. I installed the latest Robusta version 0.10.30 in a test environment of mine and noticed an issue once I configured a Webex sink, specifically that the notification messages only show up properly in the web client for Cisco Webex. When attempting to view the messages in the desktop clients (Windows / macOS), the app only showed the placeholder text message (.) without any other data.

Screenshot from Webex Web:
image

Screenshot from Webex Desktop (macOS):
image

So I started analysing this issue by dumping the adaptive card data into a file and messing around with it, until I discovered that the sent payload is violating the official Adaptive Cards v1.2 spec as the property wrap is set as a string with a boolean inside, instead of an actual boolean. So the JSON body should contain "wrap": true, not "wrap": "true" like it does today.

While the Webex web client still properly displays such semi-broken cards, the desktop client straight up refuses without any useful information. Simply switching out the couple lines of code to pass True instead of "true" fully fixes the issue on both platforms.

@CLAassistant
Copy link

CLAassistant commented Mar 8, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@arikalon1 arikalon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!
Thank you for the PR @ppmathis

@arikalon1 arikalon1 merged commit 18bdf9b into robusta-dev:master Mar 10, 2024
8 checks passed
@ppmathis ppmathis deleted the webex-sink-fix branch March 17, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants