New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add severity to node health watcher #186

Merged

arikalon1 merged 1 commit into master from add-severity-to-node-health-playbook

Jan 28, 2022

Collaborator

aantn commented Jan 28, 2022

@arikalon1 right now I set this to MEDIUM. I'm not sure about the priority on this. Ideally we would be able to differentiate between:

An unexpected unhealthy node (e.g. a node that died) which causes a service disruption because pods running on it go kaput
An Unready node which is performing a normal transition. (E.g. a node going up/down with a cluster autoscaler or spot instances.)

Right now we're really just alerting on any node that isn't ready, which matches both of those states.


          Add severity to node health watcher

6f4950f

aantn requested a review from arikalon1

January 28, 2022 14:19

Contributor

arikalon1 commented Jan 28, 2022

LGTM

arikalon1 merged commit 45cfd6b into master

arikalon1 deleted the add-severity-to-node-health-playbook branch

January 28, 2022 15:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment