Feature/Sink PagerDuty #513
Conversation
|
|
docs/catalog/sinks/PagerDuty.rst
Outdated
| - pagerduty_sink: | ||
| name: main_pagerduty_sink | ||
| api_key: <api key> # e.g. f653634653463678fadas43534506 | ||
| url: <url> # e.g. https://events.pagerduty.com/v2/enqueue/ |
There was a problem hiding this comment.
Can the URL here ever change? From the PagerDuty docs I would assume its constant in which case you can define it as a constant in the source code. No need to expose it here as a parameter.
There was a problem hiding this comment.
I was not sure because my PagerDuty account recommended me different URLs,
e.g. https://events.pagerduty.com/generic/2010-04-15/create_event.json
There was a problem hiding this comment.
@taivo123 I think we can make it a constant. The other URL is for the v1 API and PagerDuty recommends using the v2 API when possible.
| } | ||
|
|
||
| headers = {"Content-Type": "application/json"} | ||
| response = requests.post(self.url, json=body, headers=headers) |
There was a problem hiding this comment.
I think we should log an error here. When testing I put in an incorrect API key and it silently fails without notifying the user.
You can do something like this:
if response.status_code != 200:
logging.error(f"Error sending message to PagerDuty: {response.status_code}, {response.reason}, {response.text}")
There was a problem hiding this comment.
Whoops, my bad. You should check response.ok and not explicitly check for a status_code of 200. PagerDuty actually returns 202 errors, which are also OK.
No description provided.