Modified docs_build.sh to support --port option #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aantn
approved these changes
Sep 5, 2022
docs_autobuild.sh
Outdated
| @@ -1,4 +1,9 @@ | |||
| #!/bin/bash | |||
|
|
|||
| cd docs && make clean && cd .. | |||
| poetry run sphinx-autobuild docs docs/_build/html || printf '\n\nError running docs_autobuild. \nMake sure you are using poetry >= 1.1.15. \nCheck out https://docs.robusta.dev/master/developer-guide/platform/docs-contributions.html\n' | |||
|
|
|||
| if [ "$1" == "--port" ];then | |||
There was a problem hiding this comment.
@pavangudiwada instead of the if/else can we always run poetry run sphinx-autobuild $@ docs docs/_build/html and such that ./docs_autobuild.sh supports all sphinx-autobuild flags and passes them in automatically no matter what?
There was a problem hiding this comment.
Well, yep, it works without it. 😅
pavangudiwada
commented
Sep 6, 2022
docs_autobuild.sh
Outdated
| @@ -1,4 +1,9 @@ | |||
| #!/bin/bash | |||
|
|
|||
| cd docs && make clean && cd .. | |||
| poetry run sphinx-autobuild docs docs/_build/html || printf '\n\nError running docs_autobuild. \nMake sure you are using poetry >= 1.1.15. \nCheck out https://docs.robusta.dev/master/developer-guide/platform/docs-contributions.html\n' | |||
|
|
|||
| if [ "$1" == "--port" ];then | |||
There was a problem hiding this comment.
Well, yep, it works without it. 😅
pavangudiwada
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes OSError: [Errno 98] Address already in use error, caused when the default sphinx-autobuild port (8000) is reserved.