Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minikube warning and sink configuration #518

Merged
merged 2 commits into from
Sep 7, 2022

Conversation

pavangudiwada
Copy link
Contributor

  1. Added a link to Sink configuration before Robusta config generation.
  2. Added a warning about Robusta runner remaining in ContainerCreating state.

image

@pavangudiwada pavangudiwada added the documentation Improvements or additions to documentation label Sep 6, 2022
@pavangudiwada pavangudiwada self-assigned this Sep 6, 2022
@pavangudiwada pavangudiwada requested review from arikalon1 and RoiGlinik and removed request for arikalon1 September 6, 2022 09:06
@aantn
Copy link
Collaborator

aantn commented Sep 6, 2022

@pavangudiwada I think the error for being stuck in ContainerCreating state happens at a later stage, right? Not in the gen-config stage.

@pavangudiwada
Copy link
Contributor Author

@pavangudiwada I think the error for being stuck in ContainerCreating state happens at a later stage, right? Not in the gen-config stage.

Correct. But a user will be asked details in the context of local cluster(minikube) in the gen-config stage. If they are not aware of this issue. They will go ahead with the process, and it ends up not working.

In which case, they should regenerate/ modify the generated_values.yaml file etc. and go through the hassle of choosing a new cluster.

@aantn
Copy link
Collaborator

aantn commented Sep 7, 2022

@pavangudiwada Oh, right. I forgot about that.

Can we change the wording then and just say "Don't install Robusta on Minikube" or something like that. Right now we're describing an error here which isn't relevant to the current stage. We're missing the main message which is "We recommend you don't install Robusta on Minikube..."

In any event, @Sheeproid is working on a change that will make it possible to put the message in the docs at a later stage. See https://github.com/robusta-dev/robusta/pull/516/files

@pavangudiwada
Copy link
Contributor Author

@aantn Got it, will just say "We don't recommend installing Robusta on Minikube because of a recent issue with minikube. More details here

@aantn
Copy link
Collaborator

aantn commented Sep 7, 2022

@pavangudiwada perfect.

@aantn aantn merged commit 5a6c73d into robusta-dev:master Sep 7, 2022
@aantn
Copy link
Collaborator

aantn commented Sep 7, 2022

@Sheeproid FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants