add ttl option to ui sink and cluster status #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
default for 6 months
arikalon1
approved these changes
Feb 6, 2023
| @@ -7,3 +7,4 @@ class ClusterStatus(BaseModel): | |||
| version: str | |||
| last_alert_at: Optional[str] # ts | |||
| light_actions: List[str] | |||
| ttl_hours: int = 4380 # Time before unactive cluster data is deleted. 6 Months default. | |||
There was a problem hiding this comment.
Don't think we want the default value here
pavangudiwada
pushed a commit
to pavangudiwada/robusta
that referenced
this pull request
Nov 6, 2023
* add ttl option to ui sink and cluster status * default for 6 months
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
default for 6 months.
There is an option to use Interval type from Postgres but not sure its necessary.