Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small visual defect on notification #31

Closed
tknorris opened this issue Jun 29, 2014 · 1 comment
Closed

Small visual defect on notification #31

tknorris opened this issue Jun 29, 2014 · 1 comment

Comments

@tknorris
Copy link

I've noticed this addon has a small presentation issue when presenting the minutes before next scan. For example, If you run scans every 15 mins, and the scan only takes a few seconds, then there is 14 min, ~55 seconds before the next scan. The addon presents this as 14 minutes until the next scan in the notification. I think 15 minutes is a more accurate value in this case. This code change on line 256 of service.py fixes this:

minutes = int(round(cronDiff / 60.0 - hours * 60))

This change was too small to go through the whole fork/PR process. It's a minor issue but annoys me each time a scan runs ;-)

@robweber
Copy link
Owner

NIce! To be honest I've noticed this too but never did anything about it. Fix is certainly easy enough. Will merge this in and get it out with the next repo pull. I just did one so I'll wait a least a week. Soon though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants