Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Path Notifications #48

Closed
robweber opened this issue Jul 19, 2019 · 1 comment
Closed

Custom Path Notifications #48

robweber opened this issue Jul 19, 2019 · 1 comment

Comments

@robweber
Copy link
Owner

From phatboyj on the Kodi Forum

When the Notif for the custom path appears on-screen to show the expected run time of the next update for the custom path.

First the Notification pops up and starts showing the full custom path scanning from right to left, but before the full path is shown "actually about only half of the path is shown" the Notif disappears from the screen. Leaving me with 0 info for when the next time the custom path update should run, or what custom path it is to run on
"Which to my understanding is the purpose of the Notification in the first place"

Suggestions in 4 parts to make Notifications better for custom paths, from my favorite to least "With You having the option to use any, all, or, none of-course"

1.)
A combination of options 2.) and 3.) "Below"

2.)
Use the Kodi sources.xml Alias for the custom path , instead of the full path in the Notification thus allowing the user to view all pertinent info more effectively

For example in the snippet below TVShows_Whatever is the Alias given to my custom path in the Kodi sources.xml

<video>
<source>
<name>TVShows_Whatever</name>
<path pathversion="1">special://profile/addon_data/plugin.video.Whatever/TVShows/</path>
<allowsharing>true</allowsharing>
</source>
</video>

3.)
Show the Update time Info before The Path Info
For Example
X-hours, X-minutes, X days until next update for TVShows_Whatever

4.)
Make the Notification stay on screen a little longer
For Example
Maybe 5, 8, or, 10 Seconds instead of its current, "3 seconds or less in My experience so-far"

robweber added a commit that referenced this issue Jul 19, 2019
@robweber
Copy link
Owner Author

After looking into this I did a combination of 3 and 4. I swapped the update time with the path name, and also extended the display time. Hopefully this is a good fix.

I really liked the idea of showing the path alias from the sources, but I ran into a deal breaker trying to implement. There are cases where a user might be adding a sub folder of an existing source. Some people do this, and it does work with the scanner. In that case there wouldn't be an alias to pull from the sources.xml file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant