Copy TCP implementation from basic-cli #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like we had all the Roc code for TCP but none of the implementation, so I copied it what I did for basic-cli, and with some minor adjustments so it works here.
This is needed because return HTTP responses to the platform via task results.
lukewilliamboswell
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like we had all the Roc code for TCP but none of the implementation, so I copied it what I did for basic-cli, and did some minor adjustments so it works here.
Question: I also copied tcp_glue as it was. Should we regenerate here? If so, please let me know what's the right way to do this nowadays.