Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Request body, add parseFormUrlEncoded #41

Merged
merged 4 commits into from
Feb 20, 2024

Conversation

lukewilliamboswell
Copy link
Collaborator

This PR;

  • Simplifies the Request body and mime type by removing the InternalBodyBody workaround which was a workaround to get the initial basic-webserver implementation working with glue.
  • Adds the Http. parseFormUrlEncoded helper for parsing URLs and Form data
  • Regenerated glue (and cargo fmt'd)

@Anton-4 Anton-4 self-assigned this Feb 19, 2024
@Anton-4
Copy link
Collaborator

Anton-4 commented Feb 19, 2024

I'm almost done reviewing, will finish up tomorrow :)

Copy link
Collaborator

@Anton-4 Anton-4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Anton-4 Anton-4 merged commit 9f6e65c into roc-lang:main Feb 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants