Nested signatures #177

folkertdev · 2020-02-08T20:17:47Z

Various fixes for type signatures

instantiate rigid type variables into nested signatures. That makes sure the a is actually the same rigid variable in bar as in foo.

foo : List a 
foo =
    bar : List a
    bar = Nil

    bar

add all symbols from patterns to var_by_symbol. Previously this only happened for identifiers, now we look into records and tags to discover all symbols.
optimize the pattern state headers by adding the annotation of a variable when available. So where previously we'd add x => <4> (symbol points to type variable) we could now add x => Int directly if there is an annotation x : Int.

Basically, if the pattern was not just an Identifier, the defined symbols were not defined

rtfeldman

Looks awesome! Thanks for including a commented-out test for capitalized annotations vs aliases on this too. 👍

rtfeldman · 2020-02-08T22:10:03Z

tests/test_infer.rs

+        );
+    }
+
+    //    #[test]


Opened #178 to track this for later.

rtfeldman · 2020-02-08T22:16:07Z

tests/test_infer.rs

+
+                        toEmpty : List a -> List a
+                        toEmpty = \_ ->
+                            result : List a


It is SO COOL seeing this work! 😻

folkertdev and others added 4 commits February 8, 2020 16:04

instantiate rigids in nested annotations

68ccc89

extract symbols from non-identifier patterns

2790e37

Basically, if the pattern was not just an Identifier, the defined symbols were not defined

turn annotations into headers

ecd451e

Merge remote-tracking branch 'origin/trunk' into nested-signatures

97ab8da

rtfeldman approved these changes Feb 8, 2020

View reviewed changes

rtfeldman merged commit 1f064d2 into trunk Feb 8, 2020

rtfeldman deleted the nested-signatures branch February 8, 2020 22:17

Provide feedback